New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 8 u60: support changes in API - ChoiceBox, MenuButton, ... #208

Closed
jpsacha opened this Issue Aug 25, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@jpsacha
Member

jpsacha commented Aug 25, 2015

There are some changes in JavaFX8 u40, mostly in ChoiceBox, MenuButton:

Comparing ...\javafx-8.0_40\jfxrt.jar ...\javafx-8.0_60\jfxrt.jar:
***  MODIFIED CLASS: PUBLIC javafx.scene.control.ChoiceBox
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventType ON_HIDDEN
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventType ON_SHOWN
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventType ON_SHOWING
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventType ON_HIDING
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventHandler getOnAction()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventHandler getOnHidden()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventHandler getOnHiding()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventHandler getOnShowing()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventHandler getOnShown()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.beans.property.ObjectProperty onActionProperty()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.beans.property.ObjectProperty onHiddenProperty()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.beans.property.ObjectProperty onHidingProperty()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.beans.property.ObjectProperty onShowingProperty()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) javafx.beans.property.ObjectProperty onShownProperty()
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) void setOnAction(javafx.event.EventHandler)
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) void setOnHidden(javafx.event.EventHandler)
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) void setOnHiding(javafx.event.EventHandler)
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) void setOnShowing(javafx.event.EventHandler)
        +++  NEW METHOD: PUBLIC(+) STATIC(+) FINAL(+) void setOnShown(javafx.event.EventHandler)
***! MODIFIED CLASS: PUBLIC javafx.scene.control.ListView
        +++  NEW METHOD: PUBLIC(+) void refresh()
***  MODIFIED CLASS: PUBLIC javafx.scene.control.MenuButton
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventType ON_HIDDEN
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventType ON_SHOWING
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventType ON_SHOWN
        +++  NEW FIELD: PUBLIC(+) STATIC(+) FINAL(+) javafx.event.EventType ON_HIDING
***! MODIFIED CLASS: PUBLIC javafx.scene.control.TableView
        ***  MODIFIED METHOD: PUBLIC (<- PRIVATE) void refresh()
***! MODIFIED CLASS: PUBLIC javafx.scene.control.TreeTableView
        ***  MODIFIED METHOD: PUBLIC (<- PRIVATE) void refresh()
***  MODIFIED CLASS: PUBLIC javafx.scene.control.TreeView
        +++  NEW METHOD: PUBLIC(+) void refresh()
---! REMOVED CLASS: PUBLIC(-) STATIC(-) FINAL(-) javafx.scene.layout.CornerRadiiConverter
        ---! REMOVED SUPERCLASS: com.sun.javafx.css.StyleConverterImpl
        ---! REMOVED METHOD: PUBLIC(-) javafx.scene.layout.CornerRadii[] convert(javafx.css.ParsedValue, javafx.scene.text.Font)
        ---! REMOVED METHOD: PUBLIC(-) java.lang.Object convert(javafx.css.ParsedValue, javafx.scene.text.Font)
        ---! REMOVED METHOD: PUBLIC(-) javafx.scene.layout.CornerRadiiConverter getInstance()

The test for ChoiceBox are failing with 8u60:

[info] ChoiceBoxSpec:
[info] A ChoiceBox
[info] - ...
[info] - should implement all the JavaFX properties *** FAILED ***
[info]   Set("onHiding", "onAction", "onShowing", "onShown", "onHidden") was not empty 
           Missing Properties: onAction, onHidden, onHiding, onShowing, onShown (
PropertyComparator.scala:48)

@jpsacha jpsacha added this to the 8.0.*-R9 milestone Aug 25, 2015

@jpsacha jpsacha added the enhancement label Aug 25, 2015

jpsacha added a commit that referenced this issue Sep 9, 2015

Resolved Issue #208: Support changes in JavaFX 8u60 API: new properti…
…es and constants in ChoiceBox and MenuButton.

@jpsacha jpsacha closed this Sep 9, 2015

@jpsacha jpsacha changed the title from Java 8 u60: support changes om API - ChoiceBox, MenuButton, ... to Java 8 u60: support changes in API - ChoiceBox, MenuButton, ... Sep 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment