Skip to content

/ scalafx

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene's onMouseDrag* setters have incorrect type parameters, jfxsi.MouseEvent instead jfxsi.MouseDragEvent. #220

Closed
jpsacha opened this issue Oct 29, 2015 · 0 comments
Closed

Scene's onMouseDrag* setters have incorrect type parameters, jfxsi.MouseEvent instead jfxsi.MouseDragEvent. #220

jpsacha opened this issue Oct 29, 2015 · 0 comments
Labels
bug
Milestone
8.0.*-R10

Comments

@jpsacha
Copy link
Member

@jpsacha jpsacha commented Oct 29, 2015

For instance, in Scene we have

def onMouseDragEntered_=(v: jfxe.EventHandler[_ >: jfxsi.MouseEvent]) {...}

but should be

def onMouseDragEntered_=(v: jfxe.EventHandler[_ >: jfxsi.MouseDragEvent]) {...)
@jpsacha jpsacha added this to the 8.0.*-R10 milestone Oct 29, 2015
@jpsacha jpsacha added the bug label Oct 29, 2015
jpsacha added a commit that referenced this issue Oct 29, 2015
@jpsacha
Cherry-pick miscellaneous corrections from PR #196 by Benedict Lee.
Loading status checks…
587f447 
* Scene's `onMouseDrag` setters had incorrect type parameters,  `jfxsi.MouseEvent` instead `jfxsi.MouseDragEvent` - Issue #220.
* Correct some type constraints in methods using jfxe.EventHandler arguments - Issue #221.
* Correct some setter that were defined with `_(` instead of `_=(` - Issue ##222.
* Typos in documentation.
jpsacha added a commit that referenced this issue Oct 29, 2015
@jpsacha
Correct use of `jfxsi.MouseDragEvent` in SceneProperty - Issue #220.
Loading status checks…
a136857
@jpsacha jpsacha closed this Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
8.0.*-R10
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@jpsacha