Skip to content

/scalafx

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for building with Java 11 #287

Closed
jpsacha opened this issue Oct 3, 2018 · 1 comment
Closed

Add support for building with Java 11 #287

jpsacha opened this issue Oct 3, 2018 · 1 comment
Labels
SFX-11
Milestone
11-R16

Comments

@jpsacha
Copy link
Member

@jpsacha jpsacha commented Oct 3, 2018

JavaFX is not distributed with Java 11, so build will need some adjustment.
Add conditional dependencies, so build works with 10 and 11, if possible.
@jpsacha jpsacha added the SFX-11 label Oct 3, 2018
jpsacha added a commit that referenced this issue Oct 7, 2018
@jpsacha
Fixed #287: Add support for building with Java 11.
Loading status checks…
5396177
@jpsacha

This comment has been minimized.

Sign in to view
Copy link
Member Author

@jpsacha jpsacha commented Oct 7, 2018 •
edited

No need for conditional compilation on Java 10, it works the same as on Java 11.
@jpsacha jpsacha closed this Oct 7, 2018
@jpsacha jpsacha added this to the 11-R16 milestone Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SFX-11
Projects
None yet
Milestone
  11-R16
1 participant
@jpsacha
You can’t perform that action at this time.