Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return subscription from onChange like the rest of observable collections #239

Merged
merged 1 commit into from Apr 29, 2016

Conversation

@piotrm0
Copy link
Contributor

piotrm0 commented Apr 28, 2016

The ArrayBuffer collection had a subscription scheme to cancel listeners. I added the same scheme to the rest of the observable collections.

@jpsacha jpsacha merged commit 31598c0 into scalafx:master Apr 29, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jpsacha

This comment has been minimized.

Copy link
Member

jpsacha commented Apr 29, 2016

Thanks for adding the missing Subscription.

@jpsacha jpsacha added this to the 8.0.*-R11 milestone Apr 29, 2016
@jpsacha jpsacha changed the title return subscription from onChange on the rest of observable collections return subscription from onChange like the rest of observable collections Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.