Update Color.scala#311
Closed
corkine wants to merge 3 commits into
Closed
Conversation
SFX Color.grayRgb is used to wrap the grayRgb method in JavaFX. Unlike JFX's gray method, grayRgb is of type Int and has a range of 0 - 255, which corresponds to 0.0 - 1.0 of the Double type of gray. The current SFX delegates grayRgb directly to gray, and the Int type is converted and automatically converted to Double, which is wrong and cannot be checked by the checkRGB method.
Member
|
Thanks for fixing the bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFX Color.grayRgb is used to wrap the grayRgb method in JavaFX. Unlike JFX's gray method, grayRgb is of type Int and has a range of 0 - 255, which corresponds to 0.0 - 1.0 of the Double type of gray. The current SFX delegates grayRgb directly to gray, and the Int type is converted and automatically converted to Double, which is wrong and cannot be checked by the checkRGB method.