Skip to content

Support for JavaFX 17#368

Merged
jpsacha merged 3 commits into
scalafx:masterfrom
rom1dep:JavaFX17
Nov 30, 2021
Merged

Support for JavaFX 17#368
jpsacha merged 3 commits into
scalafx:masterfrom
rom1dep:JavaFX17

Conversation

@rom1dep

@rom1dep rom1dep commented Oct 22, 2021

Copy link
Copy Markdown
Contributor

This closes #362.

More in details,

➤ rg "@since 17" -c ./modules/javafx.* -g '!*module-info.java'
./modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java:1 → now wrapped
./modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java:1 → added
./modules/javafx.graphics/src/main/java/javafx/css/Stylesheet.java:1 → ignored, as we don't wrap this class yet
./modules/javafx.graphics/src/main/java/javafx/application/Platform.java:1 → added
./modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableCell.java:3 → handled the 2 deprecations, don't know what to do about `registerInvalidationListener`
./modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java:4 → ignored `registerInvalidationListener`, `unregisterInvalidationListeners`, `registerListChangeListener`, `unregisterListChangeListeners`

@jpsacha

jpsacha commented Oct 22, 2021

Copy link
Copy Markdown
Member

Build files will need to be updated too to use JavaFX 17, but since SBT/Coursier does not support JavaFX 17 yet (sbt/sbt#6564) this cannot be merged to main branch at this point. Looks that Coursier is already fixed, hopefully it will publish soon

@jpsacha jpsacha merged commit f1c0f59 into scalafx:master Nov 30, 2021
@SethTisue

Copy link
Copy Markdown
Contributor

note that SpotLight.scala hits scala/bug#12509 (as I discovered in the Scala 2 community build)

@jpsacha

jpsacha commented Dec 9, 2021

Copy link
Copy Markdown
Member

@SethTisue the build of docs in the last release took really long time (several hours). Could not figure out what was going on. Glad that that this may be narrowed down

@rom1dep

rom1dep commented Dec 9, 2021

Copy link
Copy Markdown
Contributor Author

wow, sorry for the mess :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for JavaFX 17

3 participants