Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch shutdownNow to shutdown due to excessive exceptions being logged #1003

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@tgodzik
Copy link
Collaborator

tgodzik commented Oct 18, 2019

Previously, shutdownNow would cause multiple threads to be interrupted, which would show up as a large number of exception. Now, we use shutdown(), so that threads can finish orderly.

@tgodzik tgodzik requested a review from olafurpg Oct 18, 2019
Copy link
Member

olafurpg left a comment

LGTM 👍 Nice catch!

@tgodzik tgodzik merged commit 2b4f7f3 into scalameta:master Oct 18, 2019
1 of 3 checks passed
1 of 3 checks passed
build build
Details
scalameta.metals Build #20191018.17 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tgodzik tgodzik deleted the tgodzik:shutdown branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.