Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode the workspace path directory in build digests #1015

Merged
merged 4 commits into from Oct 24, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Oct 24, 2019

Fixes #1009. Previously, when the user loaded the workspace to a docker
container then Metals would fail to connect to the Bloop build server
without providing an explanation what might be wrong. Now, Metals will
prompt the user to re-import the build.

olafurpg added 3 commits Oct 24, 2019
Fixes #1009. Previously, when the user loaded the workspace to a docker
container then Metals would fail to connect to the Bloop build server
without providing an explanation what might be wrong. Now, Metals will
prompt the user to re-import the build.
Makes it easier to run only digest tests with `testOnly -- tests.digest`
Previously, BaseDigestSuite compared digests between different temporary
directories, which would always return false since we now encode the
workspace absolute path in the build's digest. Now, BaseDigestSuite
reuses the workspace directory path between different digests.
There should only be non-abstract test suites in the test config.
@olafurpg olafurpg force-pushed the olafurpg:issue-1009 branch from 5acdc68 to 501b23c Oct 24, 2019
Copy link
Collaborator

tgodzik left a comment

Looks good! Thanks!

@tgodzik tgodzik merged commit c468862 into scalameta:master Oct 24, 2019
3 checks passed
3 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20191024.3 succeeded
Details
@olafurpg olafurpg deleted the olafurpg:issue-1009 branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.