Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bloop v1.3.5. #1017

Merged
merged 2 commits into from Oct 24, 2019
Merged

Upgrade to Bloop v1.3.5. #1017

merged 2 commits into from Oct 24, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Oct 24, 2019

No description provided.

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Oct 24, 2019

Test failures seem to be related to the SemanticDB compiler plugin

[error] Failed tests:
[error] 	tests.DocumentHighlightLspSuite
[error] 	tests.DefinitionLspSuite
[error] 	tests.FileWatcherLspSuite
[error] 	tests.ImplementationSuite
[error] 	tests.ReferenceLspSuite
[error] 	tests.CodeLensesLspSuite
[error] 	tests.QuickBuildSuite
[error] 	tests.WorkspaceSymbolLspSuite

@tgodzik could you maybe try to investigate?

@tgodzik

This comment has been minimized.

Copy link
Collaborator

tgodzik commented Oct 24, 2019

Test failures seem to be related to the SemanticDB compiler plugin

[error] Failed tests:
[error] 	tests.DocumentHighlightLspSuite
[error] 	tests.DefinitionLspSuite
[error] 	tests.FileWatcherLspSuite
[error] 	tests.ImplementationSuite
[error] 	tests.ReferenceLspSuite
[error] 	tests.CodeLensesLspSuite
[error] 	tests.QuickBuildSuite
[error] 	tests.WorkspaceSymbolLspSuite

@tgodzik could you maybe try to investigate?

Quickly checked local snapshot and seems to work :/ Will investigate more after my flight lands

@tgodzik

This comment has been minimized.

Copy link
Collaborator

tgodzik commented Oct 24, 2019

Is it possible that the source root is now badly configured? We override it in bloop now.

@tgodzik

This comment has been minimized.

Copy link
Collaborator

tgodzik commented Oct 24, 2019

Seems we specified the workspace directory badly, which pointed to the project directory.

@jvican

This comment has been minimized.

Copy link
Collaborator

jvican commented Oct 24, 2019

Can we replace the bloop script by the launcher invocation instead?

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Oct 24, 2019

@jvican can you elaborate? The tests are passing now, the bug was on the Metals side.

Travis is failing with a familiar error

 There is insufficient memory for the Java Runtime Environment to continue.

# Native memory allocation (mmap) failed to map 133693440 bytes for committing reserved memory.

# An error report file with more information is saved as:

# /home/travis/build/scalameta/metals/tests/slow/hs_err_pid6157.log

We may want to consider moving those tests to GitHub Actions 🤔

@tgodzik

This comment has been minimized.

Copy link
Collaborator

tgodzik commented Oct 24, 2019

@jvican can you elaborate? The tests are passing now, the bug was on the Metals side.

Travis is failing with a familiar error

 There is insufficient memory for the Java Runtime Environment to continue.

# Native memory allocation (mmap) failed to map 133693440 bytes for committing reserved memory.

# An error report file with more information is saved as:

# /home/travis/build/scalameta/metals/tests/slow/hs_err_pid6157.log

We may want to consider moving those tests to GitHub Actions

@jvican is talking about the script we are using to run bloop in the background. I can fix that in a separate PR. Let's merge this one and I can start working on the release tomorrow.

@tgodzik

This comment has been minimized.

Copy link
Collaborator

tgodzik commented Oct 24, 2019

Maven failure unrelated - it will be available tomorrow most likely. Will check before running release. I will experiment with adding more github actions in a separate PR since they seem to be working alright now.

@tgodzik tgodzik merged commit ddc9301 into scalameta:master Oct 24, 2019
2 of 3 checks passed
2 of 3 checks passed
build
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
scalameta.metals Build #20191024.5 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.