Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all tests into github actions #1018

Merged
merged 3 commits into from Oct 25, 2019
Merged

Move all tests into github actions #1018

merged 3 commits into from Oct 25, 2019

Conversation

@tgodzik
Copy link
Collaborator

tgodzik commented Oct 24, 2019

Previously, we would run tests on Travis, Azure and Github Actions. Now I moved all tests to run on github actions, since they seem more stable now there.

@tgodzik tgodzik force-pushed the tgodzik:fix-CIs branch 7 times, most recently from 3a03e65 to 399708e Oct 24, 2019
@tgodzik tgodzik force-pushed the tgodzik:fix-CIs branch from 399708e to 8652ff1 Oct 24, 2019

$bloopDir/bloop ng-stop
$bloopDir/bloop server &>/dev/null &
coursier launch ch.epfl.scala:bloopgun-core_2.12:$(bloop_version) -- about

This comment has been minimized.

Copy link
@jvican

jvican Oct 24, 2019

Collaborator

🎉

@@ -3,9 +3,79 @@ on:
push:
pull_request:
jobs:
build:
windows:

This comment has been minimized.

Copy link
@olafurpg

olafurpg Oct 25, 2019

Member

What do you think about waiting with this change? It's already a big enough change to move tests from Travis

This comment has been minimized.

Copy link
@tgodzik

tgodzik Oct 25, 2019

Author Collaborator

Sure, I think it's a separate thing. Will try to run those tests on windows myself and debug what;s going on.

… closing sockets more stable.
@@ -66,37 +63,6 @@ object MillLspSuite extends BaseImportSuite("mill-import") {
}
}

testAsync("force-command") {

This comment has been minimized.

Copy link
@tgodzik

tgodzik Oct 25, 2019

Author Collaborator

Those are testing the same things as the sbt tests and it seems Mill tests are less stable.

@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

tgodzik commented Oct 25, 2019

@olafurpg This looks promising :D

All checks have passed
8 successful checks

Edit: 12 minutes altogether!

@tgodzik tgodzik changed the title Move more tests into github actions and reenble Windows tests Move all tests into github actions Oct 25, 2019
@tgodzik tgodzik requested a review from olafurpg Oct 25, 2019
Copy link
Member

olafurpg left a comment

😍 :shipit:

script: bin/test.sh 'slow/testOnly -- tests.feature'
- env: TEST="sbt +cross/test"
before_script: nvm install 'lts/*' && nvm use 'lts/*'
script: sbt +cross/test
- stage: release
script:
- nvm install 'lts/*' && nvm use 'lts/*'

This comment has been minimized.

Copy link
@olafurpg

olafurpg Oct 25, 2019

Member

BTW We can migrate this job to GH Actions. The latest sbt-ci-release supports GH Actions

@olafurpg olafurpg merged commit 4d32f23 into scalameta:master Oct 25, 2019
8 checks passed
8 checks passed
Linux unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.