Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SemanticDB version to 4.2.5 and enable previously broken test #1033

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@tgodzik
Copy link
Collaborator

tgodzik commented Oct 31, 2019

No description provided.

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Nov 2, 2019

The test failure for unit/test is legitimate, you can fix it by running sbt save-expect

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Nov 2, 2019

Looks like the 4.2.4 release didn't complete the full cross-build, I have triggered a new v4.2.5 release.

@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

tgodzik commented Nov 2, 2019

Looks like the 4.2.4 release didn't complete the full cross-build, I have triggered a new v4.2.5 release.

Will try with the new one, I haven't had time to take a look at it, but will make sure everything is working with 4.2.5 on Monday

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Nov 2, 2019

The release job is running at https://travis-ci.org/scalameta/scalameta/jobs/606391878 🍿 let's hope it completes before the Travis timeout. Might be a good idea to migrate the Scalameta release job to GitHub Actions to avoid the timeouts

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Nov 2, 2019

Also probably time to upgrade the scalameta build to sbt v1.3 so that we can use the latest sbt-sonatype to speed up the publish step

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Nov 2, 2019

Release succeeded, artifacts should be on Maven in the next ~30 minutes

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Nov 2, 2019

Release is up now on Maven, all artifacts seem to have uploaded successfully

@tgodzik tgodzik force-pushed the tgodzik:semanticdb-update branch from 76c5168 to 1b2dd22 Nov 2, 2019
@tgodzik tgodzik changed the title Update SemanticDB version to 4.2.4 and enable previously broken test Update SemanticDB version to 4.2.5 and enable previously broken test Nov 2, 2019
@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

tgodzik commented Nov 2, 2019

Test failures seem legit, will take a look on Monday.

@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

tgodzik commented Nov 2, 2019

@olafurpg Also I think 2.12.7 is not published, but I think we should most likely drop it and deprecate 2.12.8.

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Nov 2, 2019

I'm in favor of dropping 2.12.7 and deprecating 2.12.8/2.12.9

@tgodzik tgodzik force-pushed the tgodzik:semanticdb-update branch from 1b2dd22 to 9845bb6 Nov 4, 2019
@tgodzik tgodzik requested review from olafurpg and marek1840 Nov 4, 2019
Copy link
Collaborator

marek1840 left a comment

There is one stale comment in the code, otherwise LGTM

@@ -284,7 +284,7 @@ object GradleLspSuite extends BaseImportSuite("gradle-import") {
_ = assertNoDiff(
client.messageRequests.peekLast(),
// only 3 projects since no empty test targets are created for gradle

This comment has been minimized.

Copy link
@marek1840

marek1840 Nov 4, 2019

Collaborator

only 3

now it's 5 ;)

This comment has been minimized.

Copy link
@tgodzik

tgodzik Nov 4, 2019

Author Collaborator

Updated the comment not to include a number - that was not important really.

@tgodzik tgodzik force-pushed the tgodzik:semanticdb-update branch from 9845bb6 to 579400c Nov 4, 2019
@tgodzik tgodzik merged commit 6af2b9f into scalameta:master Nov 4, 2019
9 checks passed
9 checks passed
Windows unit tests
Details
Linux unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@tgodzik tgodzik deleted the tgodzik:semanticdb-update branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.