Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add type annotations for public members with Scalafix #1034
gabro left a comment
Overall, I like the change and Scalafix is doing an impressive job :O
My main concerns are:
Ideally, adding an annotation should be an editor shortcut (Scalafix in the editor, anyone? :D), but since we're not there yet, can we maybe:
olafurpg left a comment
Thank you for the review! I agree the rewrite is occasionally a bit noisy but I think its overall an improvement to code readability.
A git pre-push hook would be too slow, since this requires compilation. It works just like the "remove unused imports" rewrite we have had enabled for a while now. We might want to start using sbt-scalafmt so that we can write an sbt command that runs scalafix AND scalafmt in one go.
A agree, if it turns out to be more annoying than helpful then we can turn it off. My motivation for exploring this partly comes from wanting to see if we can somehow use the new