Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegating client should not always call configure for every po… #1039

Merged
merged 1 commit into from Nov 2, 2019

Conversation

@tgodzik
Copy link
Collaborator

tgodzik commented Nov 2, 2019

Fixes #1036

Previously, we would invoke configure also on remote client which doesn't have this method configured. Now we explicitly check if it is the proper client.

@tgodzik tgodzik requested a review from olafurpg Nov 2, 2019
Copy link
Member

olafurpg left a comment

Good catch! I just hit on this issue and was trying to make sense of the error, was very confused. Thank you!

@olafurpg olafurpg changed the title Delegating client should not always call configure for every possible client Delegating client should not always call configure for every po… Nov 2, 2019
@olafurpg olafurpg merged commit cf0a20d into scalameta:master Nov 2, 2019
9 checks passed
9 checks passed
Windows unit tests
Details
Linux unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@tgodzik tgodzik deleted the tgodzik:fix-configured-client branch Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.