Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run tests on master branch or in PRs #1044

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@tgodzik
Copy link
Collaborator

tgodzik commented Nov 4, 2019

Only run tests on master branch or in PRs, previously it would run twice on a push to forked branch.

Finally figured out why we were getting 2x test notifications. Noticed that when upgrading to new sbt. I think it makes sense to still run tests on master - we can track any issues - and obviously on PRs.

…ice on a push to forked branch.
@gabro
gabro approved these changes Nov 4, 2019
Copy link
Member

gabro left a comment

ahà, nice find!

@tgodzik tgodzik merged commit 60592c9 into scalameta:master Nov 4, 2019
9 checks passed
9 checks passed
Windows unit tests
Details
Linux unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@tgodzik tgodzik deleted the tgodzik:fix-actions-running-twice branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.