Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an empty line after the package declaration before import #1051

Merged
merged 2 commits into from Nov 10, 2019

Conversation

@ckipp01
Copy link
Member

ckipp01 commented Nov 8, 2019

This will close #1054

Checks to see if there are any imports and if not, but there is a package declaration, it will add an extra new line to add padding between the package declaration and the first import.

2019-11-08 14 03 05

@ckipp01 ckipp01 added the feature label Nov 8, 2019
Copy link
Member

gabro left a comment

Minor stylistic comments, but otherwise LGTM for me 👍

Copy link
Collaborator

tgodzik left a comment

Just two small nitpicks, otherwise looks good.

Thanks for taking a look at it! 🎉

@ckipp01 ckipp01 force-pushed the ckipp01:import-padding branch from 9950577 to 70e35a9 Nov 10, 2019
@gabro
gabro approved these changes Nov 10, 2019
Copy link
Member

gabro left a comment

👍 nice!

@ckipp01 ckipp01 requested a review from tgodzik Nov 10, 2019
Copy link
Collaborator

tgodzik left a comment

LGTM! 🎉

@olafurpg olafurpg changed the title Add an empty line after the package declartion before import Add an empty line after the package declaration before import Nov 10, 2019
Copy link
Member

olafurpg left a comment

This looks amazing! Thank you @ckipp01, I'm very excited to enjoy this fix 😄

@olafurpg olafurpg merged commit c115963 into scalameta:master Nov 10, 2019
9 checks passed
9 checks passed
Windows unit tests
Details
Linux unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@ckipp01 ckipp01 deleted the ckipp01:import-padding branch Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.