Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in more documentatin for vim setup #1082

Merged
merged 1 commit into from Nov 24, 2019
Merged

Conversation

@ckipp01
Copy link
Member

ckipp01 commented Nov 23, 2019

Part of this is related to #1081 since onTypeFormatting wasn't working as expected with coc.nvim. There are some extra configuration settings that are needed to ensure this works as expected which aren't clearly documented. There was also a small bug in coc.vim that they fixed really quickly. So props to them. This now works as expected like so:

2019-11-23 21 23 42

I also added a few custom commands into the configuration and updated the vim docs to utilize them. They will make manually triggering build imports, connecting to the build server, and running doctor much easier by providing :MetalsDoctor, :MetalsImport, and :MetalsConnect commands like so:

2019-11-23 21 24 12

Copy link
Member

olafurpg left a comment

Amazing! I was just struggling the other day to trigger “import build” in vim. LGTM 👍

@ckipp01 ckipp01 merged commit 8014e5a into scalameta:master Nov 24, 2019
9 checks passed
9 checks passed
Windows unit tests
Details
Linux unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@ckipp01 ckipp01 deleted the ckipp01:vim-docs branch Nov 24, 2019
@tgodzik

This comment has been minimized.

Copy link
Collaborator

tgodzik commented Nov 25, 2019

@ckipp01 This is amazing! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.