Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest Bloop. #1096

Merged
merged 4 commits into from Dec 2, 2019
Merged

Upgrade to latest Bloop. #1096

merged 4 commits into from Dec 2, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Dec 2, 2019

This release of Bloop includes several fixes to unblock
#935

@@ -148,7 +148,7 @@ lazy val V = new {
val scalameta = "4.2.5"
val semanticdb = scalameta
val bsp = "2.0.0-M4+10-61e61e87"
val bloop = "1.3.5"
val bloop = "1.3.4+251-1d81dfe5"

This comment has been minimized.

Copy link
@olafurpg

olafurpg Dec 2, 2019

Author Member

1.3.5 was a failed release, there's no longer a v1.3.5 tag in the Bloop repo. The new version was released last night https://scalacenter.github.io/bloop/setup

This comment has been minimized.

Copy link
@tgodzik

tgodzik Dec 2, 2019

Collaborator

It would be nice to reenable windows DAP tests, but I can do it later.

This comment has been minimized.

Copy link
@olafurpg

olafurpg Dec 2, 2019

Author Member

I re-enabled the DAP tests on Windows, let's see how they do!

This release of Bloop includes several fixes to unblock
#935
@olafurpg olafurpg force-pushed the olafurpg:bloop-upgrade branch from 8517cf7 to 4961092 Dec 2, 2019
@olafurpg olafurpg requested a review from tgodzik Dec 2, 2019
@olafurpg olafurpg force-pushed the olafurpg:bloop-upgrade branch from 2278c55 to f0542cd Dec 2, 2019
)
} yield ()
}
// NOTE(olafur) this test fails unpredicatly on Windows with

This comment has been minimized.

Copy link
@tgodzik

tgodzik Dec 2, 2019

Collaborator

I think it's because the filesystem might be slower on Windows - it seems like a race. I will need to do another "Windows session" and try to fix the rest of the test.

@tgodzik
tgodzik approved these changes Dec 2, 2019
Copy link
Collaborator

tgodzik left a comment

Let's hope the DAP tests work this time! Thanks for enabling them, this will be a nice step forward towards the next release.

@tgodzik

This comment has been minimized.

Copy link
Collaborator

tgodzik commented Dec 2, 2019

Looks like most tests work, just the restart fails:

X tests.DebugProtocolSuite.restart 10006ms 
  java.util.concurrent.TimeoutException: Futures timed out after [5 seconds]
  scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:259)
  scala.concurrent.impl.Promise$DefaultPromise.result(Promise.scala:263)
  scala.concurrent.Await$.$anonfun$result$1(package.scala:220)
  scala.concurrent.BlockContext$DefaultBlockContext$.blockOn(BlockContext.scala:57)
  scala.concurrent.Await$.result(package.scala:146)
  scala.meta.internal.metals.MetalsEnrichments$XtensionScalaFuture.$anonfun$withTimeout$1(MetalsEnrichments.scala:159)
  scala.concurrent.Future$.$anonfun$apply$1(Future.scala:659)
  scala.util.Success.$anonfun$map$1(Try.scala:255)
  scala.util.Success.map(Try.scala:213)
  scala.concurrent.Future.$anonfun$map$1(Future.scala:292)
  scala.concurrent.impl.Promise.liftedTree1$1(Promise.scala:33)
  scala.concurrent.impl.Promise.$anonfun$transform$1(Promise.scala:33)
  scala.concurrent.impl.CallbackRunnable.run(Promise.scala:64)
  java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
  java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)

@marek1840 Can you take a look?

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Dec 2, 2019

I disabled the DAP restart test on Windows, we can enable it in a separate PR

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Dec 2, 2019

Another test failed on windows now, start

     """|ERROR: JDWP Unable to get JNI 1.2 environment, jvm->GetEnv() return code = -2
       |JDWP exit error AGENT_ERROR_NO_JNI_ENV(183):  [util.c:840]
       |
       |Foo
@olafurpg olafurpg force-pushed the olafurpg:bloop-upgrade branch from 1dbac1b to 92453ae Dec 2, 2019
The test failure looks legitimate, but it's unrelated to the upgrade to
Bloop.
@olafurpg olafurpg force-pushed the olafurpg:bloop-upgrade branch from 92453ae to 421192c Dec 2, 2019
@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Dec 2, 2019

I gave up on re-enabling the DAP tests on Windows

@olafurpg olafurpg merged commit 34f69a0 into scalameta:master Dec 2, 2019
9 checks passed
9 checks passed
Windows unit tests
Details
Linux unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@olafurpg olafurpg deleted the olafurpg:bloop-upgrade branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.