Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAP-tests] Adapt new lines to the underlying OS #1124

Merged

Conversation

@marek1840
Copy link
Collaborator

marek1840 commented Dec 2, 2019

Previously, waiting for output containing new lines was system dependent - we were expecting \n even on windows. Now, we are automatically adapting unix new lines to the underlying OS.

@marek1840 marek1840 force-pushed the marek1840:dap/enable-win-tests-after-bloop-update branch 2 times, most recently from 0d75e23 to 981ecf8 Dec 2, 2019
@marek1840 marek1840 marked this pull request as ready for review Dec 4, 2019
@marek1840 marek1840 force-pushed the marek1840:dap/enable-win-tests-after-bloop-update branch 5 times, most recently from 37c33b7 to 5b05722 Dec 4, 2019
marek1840 added 3 commits Dec 2, 2019
Previously, failing request would not affect the consecutive
requests. Now, if the request fails, no other request will be accepted.
Additionally, first error notification sent from the server causes
the debugger to fail as well.
@marek1840 marek1840 force-pushed the marek1840:dap/enable-win-tests-after-bloop-update branch from f3460a5 to 03568cd Dec 4, 2019
@marek1840 marek1840 changed the title Enable debug protocol tests on windows [DAP-tests] Adapt new lines to the underlying OS Dec 4, 2019
@marek1840 marek1840 requested a review from tgodzik Dec 4, 2019
@marek1840 marek1840 added the debug label Dec 4, 2019
@tgodzik
tgodzik approved these changes Dec 4, 2019
Copy link
Collaborator

tgodzik left a comment

LGTM

@tgodzik tgodzik merged commit 77e992d into scalameta:master Dec 4, 2019
10 checks passed
10 checks passed
ubuntu-latest tests
Details
windows-latest tests
Details
macOS-latest tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.