Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git fetch --unshallow to restore version number #1143

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Dec 4, 2019

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Dec 4, 2019

First attempt failed with

fatal: --unshallow on a complete repository does not make sense
@olafurpg olafurpg force-pushed the olafurpg:unshallow-fetch branch from 66ba59f to 199dd1f Dec 4, 2019
@olafurpg olafurpg force-pushed the olafurpg:unshallow-fetch branch from 199dd1f to cd3f0f9 Dec 4, 2019
@olafurpg olafurpg requested a review from tgodzik Dec 4, 2019
@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Dec 4, 2019

Logs look positive

 [info] Set current project to default-a8016c (in build file:/home/runner/work/metals/metals/)
[info] interfaces / version
[info] 	0.7.6+395-a3d33193-SNAPSHOT

We can give this a try

@ckipp01
ckipp01 approved these changes Dec 4, 2019
Copy link
Member

ckipp01 left a comment

Nice, that's simple. LGTM!

@olafurpg olafurpg merged commit 2ce1c78 into scalameta:master Dec 4, 2019
10 checks passed
10 checks passed
ubuntu-latest tests
Details
windows-latest tests
Details
macOS-latest tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@olafurpg olafurpg deleted the olafurpg:unshallow-fetch branch Dec 4, 2019
@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Dec 4, 2019

I just realized this PR won't have any effect since the CI release happens on Travis. I pushed 2cb4e3b to master because we don't run PR tests on Travis.

@ckipp01

This comment has been minimized.

Copy link
Member

ckipp01 commented Dec 4, 2019

I just realized this PR won't have any effect since the CI release happens on Travis. I pushed 2cb4e3b to master because we don't run PR tests on Travis.

Haha, of course. We can just remove it and do the same thing for Travis I'm assuming? Is there a specific reason we cant use actions to release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.