Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update directory watcher to 0.9.6" #1144

Merged
merged 1 commit into from Dec 4, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Dec 4, 2019

This reverts commit a6278fb.

I'm still hitting on crashes when running the tests locally on my computer

Exception in thread "pool-2-thread-2" java.lang.NoSuchFieldError: SIZE
	at com.zaxxer.nuprocess.osx.OsxProcess.createPosixSpawnFileActions(OsxProcess.java:191)
	at com.zaxxer.nuprocess.osx.OsxProcess.createPosixPipes(OsxProcess.java:150)
	at com.zaxxer.nuprocess.osx.OsxProcess.start(OsxProcess.java:58)
	at com.zaxxer.nuprocess.osx.OsxProcessFactory.createProcess(OsxProcessFactory.java:34)
	at com.zaxxer.nuprocess.NuProcessBuilder.start(NuProcessBuilder.java:266)
	at scala.meta.internal.process.SystemProcess$.run(SystemProcess.scala:27)
	at scala.meta.internal.pantsbuild.Filemap$.fromPants(Filemap.scala:40)
	at scala.meta.internal.pantsbuild.BloopPants$.$anonfun$bloopInstall$1(BloopPants.scala:146)
	at scala.runtime.java8.JFunction0$mcI$sp.apply(JFunction0$mcI$sp.java:23)
	at scala.meta.internal.pantsbuild.BloopPants$.interruptedTry(BloopPants.scala:122)
  | => sat scala.meta.internal.pantsbuild.BloopPants$.bloopInstall(BloopPants.scala:129)
	at scala.meta.internal.builds.PantsBuildTool.$anonfun$bloopInstall$1(PantsBuildTool.scala:9

I'm on Mojave 10.14.6 (18G95) and I can reproduce with Java 1.8.0_111, adopt@1.8.0-232 and GraalVM 19.3 for JDK 11. It's concerning that the CI still passed on macOS with the upgrade.

This reverts commit a6278fb.
@tgodzik
tgodzik approved these changes Dec 4, 2019
@olafurpg olafurpg merged commit ae082d5 into scalameta:master Dec 4, 2019
10 checks passed
10 checks passed
ubuntu-latest tests
Details
windows-latest tests
Details
macOS-latest tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@olafurpg olafurpg deleted the olafurpg:revert-directory-watcher branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.