Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary `asInstanceOf` And Unused Values #1151

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@isomarcte
Copy link
Contributor

isomarcte commented Dec 5, 2019

An asInstanceOf was being used to case a value to a subtype, but a pattern match had already safely created a typed value.

This commit also removes two unused named variables pattern matches in HtmlConverter.scala

An `asInstanceOf` was being used to case a value to a subtype, but a pattern match had already safely created a typed value.

This commit also removes two unused named variables pattern matches in `HtmlConverter.scala`
@tgodzik
tgodzik approved these changes Dec 5, 2019
Copy link
Collaborator

tgodzik left a comment

Looks good! Thanks!

@tgodzik tgodzik merged commit 52007af into scalameta:master Dec 5, 2019
10 checks passed
10 checks passed
ubuntu-latest tests
Details
windows-latest tests
Details
macOS-latest tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@isomarcte isomarcte deleted the isomarcte:cleanup-htmlconverter branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.