Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Cleanup MarkdownGenerator #1152
* `blocksToMarkdown` had an unused parameter `listLevel`. It appears as though the intent was to pass this value to the `blockToMarkdown` function which also has a parameter by the same name to keep track of indentation level. This is now the case. As a result of this change, there is now no situation in which the default argument value of `listLevel` in the function `blockToMarkdown` is used, thus it was removed. * In the function `blockToMarkdown` the matches on `UnorderedList` and `OrderedList` are identical code, except for choosing a different bullet character, either `-` or `*`, based on the type. This logic was factored out into two new functions, `listBlockIndent` and `listBlocksIndent` which allow for a reduction in repeated code in the body of `blockToMarkdown`.
tgodzik merged commit
Dec 5, 2019
10 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.