Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Scalafmt v2.3.1 #1162

Merged
merged 3 commits into from Dec 7, 2019
Merged

Upgrade to Scalafmt v2.3.1 #1162

merged 3 commits into from Dec 7, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Dec 6, 2019

No description provided.

@olafurpg olafurpg force-pushed the olafurpg:scalafmt-upgrade branch from d494757 to e11ef3b Dec 7, 2019
@olafurpg olafurpg requested a review from gabro Dec 7, 2019
@gabro
gabro approved these changes Dec 7, 2019
Copy link
Member

gabro left a comment

LGTM! I quite like the new formatting

|maxColumn=40
|^^^^^^^^^^^^
|""".stripMargin
s"""|.scalafmt.conf:1:1: error: missing setting 'version'. To fix this problem, add the following line to .scalafmt.conf: 'version=${V.scalafmtVersion}'.

This comment has been minimized.

Copy link
@gabro

gabro Dec 7, 2019

Member

👍

@olafurpg olafurpg merged commit 1c23e3f into scalameta:master Dec 7, 2019
10 of 11 checks passed
10 of 11 checks passed
ubuntu-latest tests
Details
windows-latest tests windows-latest tests
Details
macOS-latest tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@olafurpg olafurpg deleted the olafurpg:scalafmt-upgrade branch Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.