Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing the Windows CI #1164

Merged
merged 5 commits into from Dec 8, 2019
Merged

Try fixing the Windows CI #1164

merged 5 commits into from Dec 8, 2019

Conversation

@gabro
Copy link
Member

gabro commented Dec 6, 2019

Let's see whether this fixes the CI on Windows.

My suspicion is that the recent rewrite of the Windows Sbt launcher (sbt/sbt-launcher-package@b5fd78f#diff-0e467aba72fad1d1010d8efae1c500d6) has a regression in the handling of .jvmopts

@gabro

This comment has been minimized.

Copy link
Member Author

gabro commented Dec 6, 2019

mm, I guess I was wrong. Windows CI is still failing even with 1.3.3

gabro added 2 commits Dec 7, 2019
@gabro gabro changed the title Rollback to Sbt 1.3.3 Try fixing the Windows CI Dec 7, 2019
@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Dec 7, 2019

The logs make it look like the issue is not caused by sbt but by the bash script mode on Windows.

Resolution error: Error downloading ch.epfl.scala:bloopgun-core_2.12:1.3.42511815
  not found: C:\Users\runneradmin\.ivy2\local\ch.epfl.scala\bloopgun-core_2.12\1.3.42511815\ivys\ivy.xml
  not found: https://repo1.maven.org/maven2/ch/epfl/scala/bloopgun-core_2.12/1.3.42511815/bloopgun-core_2.12-1.3.42511815.pom

I wonder if GitHub Actions just updated their windows-latest image 🤔

@gabro

This comment has been minimized.

Copy link
Member Author

gabro commented Dec 7, 2019

@olafurpg ah, that might actually be. On the documentation, you can see

image

https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners

which hints at the fact that something has changed on December 3rd (recently)

@gabro

This comment has been minimized.

Copy link
Member Author

gabro commented Dec 7, 2019

@olafurpg I’ve found an issue with a regex in the test script which didn’t play well with the “snapshot” version of bloop.
I’ve fixed it in the latest commit, but it seems unrelated to the JVM failure

@olafurpg olafurpg force-pushed the gabro:rollback-sbt branch from daa34c6 to 023f99d Dec 8, 2019
@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Dec 8, 2019

Back to green CI 🎉

@olafurpg olafurpg merged commit 5dee408 into scalameta:master Dec 8, 2019
11 checks passed
11 checks passed
ubuntu-latest tests
Details
windows-latest tests
Details
macOS-latest tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.