Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Runtime Error In Metals Bench #1165

Conversation

@isomarcte
Copy link
Contributor

isomarcte commented Dec 6, 2019

A path to file needed to run the CompletionBench benchmark was hard coded as scala 2.12.8. Since this is no longer the version of Scala used to compile metals this fails at runtime.

This was changed to use sbt-buildinfo to populate the correct version of scala for the given build from the build definition directly.

A path to file needed to run the `CompletionBench` benchmark was hard coded as scala `2.12.8`. Since this is no longer the version of Scala used to compile `metals` this fails at runtime.

This was changed to use sbt-buildinfo to populate the correct version of scala for the given build from the build definition directly.
@ckipp01
ckipp01 approved these changes Dec 7, 2019
Copy link
Member

ckipp01 left a comment

This looks good. Thanks for the contribution!

LGTM!

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Dec 8, 2019

Ignoring unrelated CI failures. The Windows issues should already be fixed in #1164

@olafurpg olafurpg merged commit 9533e87 into scalameta:master Dec 8, 2019
9 of 11 checks passed
9 of 11 checks passed
ubuntu-latest tests
Details
windows-latest tests windows-latest tests
Details
macOS-latest tests macOS-latest tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.