Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Sort auto-completed exhaustive match'es by declaration order #1174
This PR enables metals to sort auto-completed exhaustive match cases by declaration order, instead of the order of
Here's a test of match exhaustive completion for
Thank you for giving a kind instruction for implementing this @olafurpg ! It's insightful and made me more comfortable to read through the metals' codebase :) https://github.com/scalameta/metals-feature-requests/issues/49#issuecomment-544236184
https://github.com/scalameta/metals-feature-requests/issues/49 This commit enable metals to sort auto-completed exhaustive match'es by declaration order. However, it caluculates their declaration positions from the infromation retrieved from interactive compiler, and we cannot sort them if the interactive compiler hasn't yet loaded the symbols.
gabro left a comment
Thank you for working on this @tanishiking!
I've given a cursory review and left a few minor comments.
Also, I've moved the referenced issue from the feature request repo to the main issue tracker, so that it's clear it's beeing worked on.