Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore flaky BspSwitchSuite and reenable FoldingRangeSuite on Windows. #1177

Merged
merged 2 commits into from Dec 10, 2019

Conversation

@tgodzik
Copy link
Collaborator

tgodzik commented Dec 9, 2019

BspSwitchSuite is consistently failing on CI for Windows, but FoldingRangeSuite might be reenabled after recent fixes to the reliability of the directory watcher within tests.

Copy link
Member

olafurpg left a comment

It’s tricky to write tests that run reliably on all platforms 😅

Copy link
Member

ckipp01 left a comment

Holds back curse words about CI tests on windows...

@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

tgodzik commented Dec 10, 2019

Now they're going OOM :/

@tgodzik tgodzik force-pushed the tgodzik:ignore-flaky branch from 44287fb to 6d25da9 Dec 10, 2019
@gabro

This comment has been minimized.

Copy link
Member

gabro commented Dec 10, 2019

Could it be the -Xmx4G option which is a bit much?

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Dec 10, 2019

Yes, I think the -Xmx4g option may be too much, iirc the GitHub Actions machines only have 2gb

@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

tgodzik commented Dec 10, 2019

Yes, I think the -Xmx4g option may be too much, iirc the GitHub Actions machines only have 2gb

Hmm... according to https://help.github.com/en/actions/automating-your-workflow-with-github-actions/virtual-environments-for-github-hosted-runners they have 7gb. But it might be Bloop server taking up some of it.

@gabro

This comment has been minimized.

Copy link
Member

gabro commented Dec 10, 2019

all green!

@gabro gabro merged commit c82bfb7 into scalameta:master Dec 10, 2019
11 checks passed
11 checks passed
ubuntu-latest unit tests
Details
windows-latest unit tests
Details
macOS-latest unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.