Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update The Getting Started Documentation For Java 11 #1194

Merged

Conversation

@isomarcte
Copy link
Contributor

isomarcte commented Dec 16, 2019

No description provided.

Copy link
Member

gabro left a comment

Does this mean Java 8 won’t work anymore?
I don’t think that’s the case, is it?

Can we say “Java 8 or 11”?

@isomarcte

This comment has been minimized.

Copy link
Contributor Author

isomarcte commented Dec 16, 2019

@gabro As of the merging of #1171 CI is building this with JDK 11. Not all code which builds with JDK 8 will build with JDK 11. That was the impetus for

If people are using JDK 8 they may think everything is fine, but then it will fail in CI.

So I think we should encourage them to only dev on metals with JDK 11 or >.

@isomarcte

This comment has been minimized.

Copy link
Contributor Author

isomarcte commented Dec 16, 2019

That if metals builds on JDK 11 it should build JDK 8, but not the other way around.

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Dec 16, 2019

@isomarcte i still develop Metals on JDK 8 and expect to continue to do so for at least the next year. Our contributing docs should say that either JDK 8 or 11 is fine.

@olafurpg

This comment has been minimized.

Copy link
Member

olafurpg commented Dec 16, 2019

That if metals builds on JDK 11 it should build JDK 8, but not the other way around.

The same is true for contributors who work on JDK 11 and use APIs that are not available on JDK 8

@isomarcte

This comment has been minimized.

Copy link
Contributor Author

isomarcte commented Dec 16, 2019

The same is true for contributors who work on JDK 11 and use APIs that are not available on JDK 8

That's a fair point. I'll update it.

@isomarcte

This comment has been minimized.

Copy link
Contributor Author

isomarcte commented Dec 16, 2019

Updated

@isomarcte isomarcte force-pushed the isomarcte:update-documentation-for-jdk-11 branch from bf6de55 to 1eaaced Dec 16, 2019
Copy link
Member

olafurpg left a comment

Thank you!

@olafurpg olafurpg merged commit f4d60a2 into scalameta:master Dec 16, 2019
12 checks passed
12 checks passed
windows-latest unit tests
Details
macOS-latest unit tests
Details
ubuntu-latest unit tests
Details
ubuntu-latest unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
@isomarcte isomarcte deleted the isomarcte:update-documentation-for-jdk-11 branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.