Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in documenation for coc-metals #1197

Merged
merged 4 commits into from Dec 20, 2019
Merged

add in documenation for coc-metals #1197

merged 4 commits into from Dec 20, 2019

Conversation

@ckipp01
Copy link
Member

ckipp01 commented Dec 17, 2019

Hopefully, this will help with the review of coc-metals. I did my best to update all of the documentation and include images of all the new things that coc-metals offers vim users.

I think it's at a point where it's very stable for downloading new versions, managing configuration options, and using commands to restart the server etc. I've found the experience much more pleasant than managing it by hand. I think it'd be cool to have this included in the next release.

I think that the extension should probably be looked at by someone on the team first to make sure it's sane, but everything seems to be working alright, and the code is very similar to that of the vs code extension. In the future, we may be able to extract out a common module to publish and share as well between the two of them.

Package is here
Repo is here

EDIT: Removed the draft status since I think this is ready to go 馃憤

Copy link
Member

olafurpg left a comment

Amazing work @ckipp01! I am super excited to finally have a proper vim integration with smooth installation. Only one blocking comment on the user configuration table, otherwise LGTM 馃憤

Are there any vim users who could give these instructions a try before we update the website?

docs/contributors/updating-website.md Show resolved Hide resolved
docs/editors/vim.md Show resolved Hide resolved
docs/editors/vim.md Outdated Show resolved Hide resolved
@ckipp01 ckipp01 requested a review from olafurpg Dec 18, 2019
@ckipp01 ckipp01 marked this pull request as ready for review Dec 18, 2019
@ckipp01 ckipp01 force-pushed the ckipp01:coc-nvim branch from 28e3ad0 to b564023 Dec 18, 2019
Copy link
Member

gabro left a comment

Really cool! I would also update the editors table here https://scalameta.org/metals/docs/editors/overview.html to mark Vim as "Single click" instead of "few steps" since most of the installation is automated now.

I would also go through the same page and make sure that the table is up-to-date in general (e.g. there are a couple of notes about Vim that I'm not sure they are try anymore)

docs/contributors/updating-website.md Outdated Show resolved Hide resolved
@ckipp01 ckipp01 requested a review from gabro Dec 19, 2019
@ckipp01

This comment has been minimized.

Copy link
Member Author

ckipp01 commented Dec 20, 2019

I would also go through the same page and make sure that the table is up-to-date in general (e.g. there are a couple of notes about Vim that I'm not sure they are try anymore)

Most of these are up to date still, but as some more things get added, i'll continue to check back here and update.

@ckipp01 ckipp01 force-pushed the ckipp01:coc-nvim branch from 640baf4 to 968aa61 Dec 20, 2019
@gabro
gabro approved these changes Dec 20, 2019
Copy link
Member

gabro left a comment

馃嵕

@ckipp01 ckipp01 merged commit 5ca47c5 into scalameta:master Dec 20, 2019
12 checks passed
12 checks passed
windows-latest jdk-11 unit tests
Details
macOS-latest jdk-11 unit tests
Details
ubuntu-latest jdk-8 unit tests
Details
ubuntu-latest jdk-11 unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
@ckipp01 ckipp01 deleted the ckipp01:coc-nvim branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.