Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
add in documenation for coc-metals #1197
Hopefully, this will help with the review of
I think it's at a point where it's very stable for downloading new versions, managing configuration options, and using commands to restart the server etc. I've found the experience much more pleasant than managing it by hand. I think it'd be cool to have this included in the next release.
I think that the extension should probably be looked at by someone on the team first to make sure it's sane, but everything seems to be working alright, and the code is very similar to that of the vs code extension. In the future, we may be able to extract out a common module to publish and share as well between the two of them.
EDIT: Removed the draft status since I think this is ready to go
olafurpg left a comment
Amazing work @ckipp01! I am super excited to finally have a proper vim integration with smooth installation. Only one blocking comment on the user configuration table, otherwise LGTM
Are there any vim users who could give these instructions a try before we update the website?
gabro left a comment
Really cool! I would also update the editors table here https://scalameta.org/metals/docs/editors/overview.html to mark Vim as "Single click" instead of "few steps" since most of the installation is automated now.
I would also go through the same page and make sure that the table is up-to-date in general (e.g. there are a couple of notes about Vim that I'm not sure they are try anymore)
Most of these are up to date still, but as some more things get added, i'll continue to check back here and update.