Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements to Pants export step #1198

Merged
merged 3 commits into from Dec 17, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Dec 17, 2019

See individual commits for details. In summary:

  • faster bloop test for ScalaTest targets
  • increased compatibility with older versions of Pants
  • improved UX for Pants targets that use recursive **/*.scala globs
olafurpg added 3 commits Dec 16, 2019
This change speeds up `bloop test` invocations by 1-2 seconds on every
run. See scalatest/scalatest#1739 for more details.
Previously, when exporting Pants targets to Bloop, we always listed out
individual source files for each target. This approach had the problem
that we needed to update the Bloop JSON files when a new file got
created. Now, for Pants targets that use the recursive `**/*.scala`
file glob, we use source directories instead of source files making it
possible for bloop to catch new files as they are created.
@olafurpg olafurpg force-pushed the olafurpg:faster-framework branch from dd3df75 to e8be2aa Dec 17, 2019
@olafurpg olafurpg merged commit b1cc89c into scalameta:master Dec 17, 2019
12 checks passed
12 checks passed
windows-latest unit tests
Details
macOS-latest unit tests
Details
ubuntu-latest unit tests
Details
ubuntu-latest unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
@olafurpg olafurpg deleted the olafurpg:faster-framework branch Dec 17, 2019
private def globsFromObject(value: Value): List[String] = value match {
case Obj(obj) =>
obj.get("globs") match {
case Some(arr: Arr) =>

This comment has been minimized.

Copy link
@wiwa

wiwa Dec 17, 2019

why not map for these case matches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.