Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several more improvements to the Pants export #1203

Merged
merged 5 commits into from Dec 18, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Dec 18, 2019

No description provided.

olafurpg added 5 commits Dec 18, 2019
Previously, we incorrectly used the "resources" field in the Bloop JSON config.
The "resources" field is only supposed to contain resources that are
defined in that project. We included all transitive dependencies
resources at every Bloop project, resulting in duplicate resource
entries.

Now, we add the resources to the classpath entry instead, which is
interpreted as "transitive resources".
Previously, goto definition didn't work for symbols that were defined in
the Pants build but were not defined the the "target roots" (i.e., the
targets we export to Bloop). This was a regression from
https://github.com/scalameta/metals/pull/1181/files, which we revert in
this commit by adding the source directories back into the "resolution"
field.
Previously, the export step failed when exporting more than 500 source
files, which happened easily even for small/medium sized targets.
@olafurpg olafurpg merged commit 97105c8 into scalameta:master Dec 18, 2019
12 checks passed
12 checks passed
windows-latest jdk-11 unit tests
Details
macOS-latest jdk-11 unit tests
Details
ubuntu-latest jdk-8 unit tests
Details
ubuntu-latest jdk-11 unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
@olafurpg olafurpg deleted the olafurpg:resources-classpath branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.