Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Several more improvements to the Pants export #1203
Previously, we incorrectly used the "resources" field in the Bloop JSON config. The "resources" field is only supposed to contain resources that are defined in that project. We included all transitive dependencies resources at every Bloop project, resulting in duplicate resource entries. Now, we add the resources to the classpath entry instead, which is interpreted as "transitive resources".
Previously, goto definition didn't work for symbols that were defined in the Pants build but were not defined the the "target roots" (i.e., the targets we export to Bloop). This was a regression from https://github.com/scalameta/metals/pull/1181/files, which we revert in this commit by adding the source directories back into the "resolution" field.
Previously, the export step failed when exporting more than 500 source files, which happened easily even for small/medium sized targets.
olafurpg merged commit
Dec 18, 2019
12 checks passed
12 checks passed
windows-latest jdk-11 unit testsDetails
macOS-latest jdk-11 unit testsDetails
ubuntu-latest jdk-8 unit testsDetails
ubuntu-latest jdk-11 unit testsDetails
LSP integration testsDetails
Scala cross testsDetails
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.