Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued improvements to Pants export #1210

merged 2 commits into from Dec 20, 2019

Continued improvements to Pants export #1210

merged 2 commits into from Dec 20, 2019


Copy link

olafurpg commented Dec 19, 2019

The edit/compile/test feedback loop with the new JUnit test runner.

2019-12-19 21 40 12

@olafurpg olafurpg marked this pull request as ready for review Dec 19, 2019
Previously, while exporting the build the user was unable to interact
with pants through the terminal. Now we use the --concurrent flag which
means the command may run a bit slower but at least the user can
interact with Pants while the export is running.
@olafurpg olafurpg force-pushed the olafurpg:junit branch 2 times, most recently from 75175f4 to e709f3d Dec 19, 2019
Previously, we were only able to run ScalaTest suites but not vanilla
JUnit test suites. Now, we can run both ScalaTest and JUnit suites using
the same JUnit test runner. The test runner is a fork that adds the ability to
automatically infer missing `@RunWith(classOf[JUnitRunner])` for
ScalaTest suites.

One nice benefit of this change is that the JUnit test runner has much
better performance. I'm seeing lower-end 100ms test runtimes with JUnit
that previously took ~500ms with ScalaTest. The console output is not
formatted as nicely but I can live with that.
@olafurpg olafurpg force-pushed the olafurpg:junit branch from e709f3d to d6142c6 Dec 20, 2019
@olafurpg olafurpg merged commit 46a17b5 into scalameta:master Dec 20, 2019
12 checks passed
12 checks passed
windows-latest jdk-11 unit tests
macOS-latest jdk-11 unit tests
ubuntu-latest jdk-8 unit tests
ubuntu-latest jdk-11 unit tests
Sbt integration
Maven integration
Gradle integration
Mill integration
Pants integration
LSP integration tests
Scala cross tests
@olafurpg olafurpg deleted the olafurpg:junit branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.