Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support breakpoints in java static methods and nested classes #1214

Conversation

@marek1840
Copy link
Collaborator

marek1840 commented Dec 20, 2019

Previously, setting breakpoints in java static methods or nested/anonymous classes didn't work.

@marek1840 marek1840 force-pushed the marek1840:dap/breakpoints/support-java-static-methods branch from 3621831 to 30cbd4a Dec 20, 2019
@marek1840 marek1840 marked this pull request as ready for review Dec 20, 2019
@marek1840 marek1840 requested review from olafurpg and tgodzik and removed request for olafurpg Dec 20, 2019
@tgodzik
tgodzik approved these changes Jan 2, 2020
Copy link
Collaborator

tgodzik left a comment

LGTM - just one question otherwise.

case Language.JAVA =>
def isTypeSymbol(symbol: SymbolInformation): Boolean = {
val kind = symbol.kind
kind.isClass || kind.isInterface

This comment has been minimized.

Copy link
@tgodzik

tgodzik Jan 2, 2020

Collaborator

What about enums?

This comment has been minimized.

Copy link
@marek1840

marek1840 Jan 7, 2020

Author Collaborator

Good catch, thanks!
It turns out enums have a class kind, so they are already covered. Nevertheless, I have added a test case for them.

@marek1840 marek1840 force-pushed the marek1840:dap/breakpoints/support-java-static-methods branch from 30cbd4a to 462dcea Jan 7, 2020
@marek1840 marek1840 merged commit 642d815 into scalameta:master Jan 7, 2020
12 checks passed
12 checks passed
windows-latest jdk-11 unit tests
Details
macOS-latest jdk-11 unit tests
Details
ubuntu-latest jdk-8 unit tests
Details
ubuntu-latest jdk-11 unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.