Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove showMessage and showMessageRequest configuration options #1222

Merged
merged 2 commits into from Dec 27, 2019

Conversation

@gabro
Copy link
Member

gabro commented Dec 26, 2019

These were only customized by the Sublime Text LSP client, which now
has proper support for the window/showMessage and
window/showMessageRequest notifications (see #443 and #1218)

I think these options served their purpose of getting the most popular editors on-board and can now be removed.

Copy link
Member

ckipp01 left a comment

LGTM!

These were only customized by the Sublime Text client, which now
has proper support for the window/showMessage and
window/showMessageRequest notifications.
@gabro gabro force-pushed the gabro:remove-configs branch from eb95440 to 0cdfbdd Dec 26, 2019
It was once used by the vim-lsc configuration, but it seems unused now
@gabro

This comment has been minimized.

Copy link
Member Author

gabro commented Dec 27, 2019

I've also removed isNoInitialized since it was unused (and undocumented)

@gabro gabro requested a review from olafurpg Dec 27, 2019
Copy link
Member

olafurpg left a comment

LGTM 👍 One part of me is tempted to keep these around "just in case" another editor with limited LSP support pops up but the other part of me thinks it's great to clean up dead code like this. We can always revert this in case we need it another time, removing code is awesome 😎

@gabro

This comment has been minimized.

Copy link
Member Author

gabro commented Dec 27, 2019

I agree with the split sentiment, but I ultimately consider those settings a list of quirks that should decrease over time, since standard LSP support for editors keeps getting better and better

@gabro gabro merged commit c2c6ada into scalameta:master Dec 27, 2019
11 of 12 checks passed
11 of 12 checks passed
windows-latest jdk-11 unit tests windows-latest jdk-11 unit tests
Details
macOS-latest jdk-11 unit tests
Details
ubuntu-latest jdk-8 unit tests
Details
ubuntu-latest jdk-11 unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.