Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard 'code' from BSP diagnostics #1232

Merged
merged 1 commit into from Dec 30, 2019
Merged

Discard 'code' from BSP diagnostics #1232

merged 1 commit into from Dec 30, 2019

Conversation

@gabro
Copy link
Member

gabro commented Dec 30, 2019

Fixes #1220

This is a temporary fix that discards the code property from BSP diagnostics. If we decide to change the code property semantics in BSP, then we can revert this fix. See the discussion here scalacenter/bloop#1135

@gabro gabro requested a review from olafurpg Dec 30, 2019
Copy link
Member

olafurpg left a comment

I think this is the best solution for now

@gabro

This comment has been minimized.

Copy link
Member Author

gabro commented Dec 30, 2019

Windows CI failure is unrelated

@gabro gabro merged commit 49f0c5f into scalameta:master Dec 30, 2019
11 of 12 checks passed
11 of 12 checks passed
windows-latest jdk-11 unit tests windows-latest jdk-11 unit tests
Details
macOS-latest jdk-11 unit tests
Details
ubuntu-latest jdk-8 unit tests
Details
ubuntu-latest jdk-11 unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
@gabro gabro deleted the gabro:no-code branch Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.