Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky test cases #1238

Merged
merged 1 commit into from Jan 2, 2020
Merged

Disable flaky test cases #1238

merged 1 commit into from Jan 2, 2020

Conversation

@olafurpg
Copy link
Member

olafurpg commented Jan 1, 2020

See #1182

@ckipp01
ckipp01 approved these changes Jan 1, 2020
Copy link
Member

ckipp01 left a comment

It looks like the other two tests that failed during this build have also somewhat consistently been failing, which is frustrating, but not related to this.

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Jan 1, 2020

I disabled the other flaky tests as well.

@olafurpg olafurpg force-pushed the olafurpg:flaky-pants branch from 2f6fe89 to 4016022 Jan 1, 2020
@olafurpg olafurpg changed the title Disable flaky test case. Disable flaky test cases Jan 2, 2020
_ = assertStatus(_.isInstalled)
} yield ()
}
// TODO(olafur) re-enable this test when it's no longer flaky

This comment has been minimized.

Copy link
@tgodzik

tgodzik Jan 2, 2020

Collaborator

Why are we totally disabling this maven test? I haven't seen it fail previously. And it's not really related to the linked issue 🤔

// TODO: renable when this test is no longer flaky on Windows
// https://github.com/scalameta/metals/pull/1238/checks?check_run_id=370216834
// [1.321s][warning][os,thread] Failed to start thread - _beginthreadex failed (EACCES) for attributes: stacksize: default, flags: CREATE_SUSPENDED STACK_SIZE_PARAM_IS.
if (!isWindows)

This comment has been minimized.

Copy link
@tgodzik

tgodzik Jan 2, 2020

Collaborator

I think all of those test fail sometimes, but rather rare. I don't think we should remove them on Windows, since they are pretty neccessary for making sure debugging works on Windows.

See #1182
@olafurpg olafurpg force-pushed the olafurpg:flaky-pants branch from 2f5a11b to 65f2765 Jan 2, 2020
Copy link
Member Author

olafurpg left a comment

@tgodzik I reverted the last two commits, let's see how that goes :)

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Jan 2, 2020

CI is green!

@olafurpg olafurpg requested a review from tgodzik Jan 2, 2020
@tgodzik
tgodzik approved these changes Jan 2, 2020
Copy link
Collaborator

tgodzik left a comment

LGTM!

@olafurpg olafurpg merged commit 2b37a36 into scalameta:master Jan 2, 2020
12 checks passed
12 checks passed
windows-latest jdk-11 unit tests
Details
macOS-latest jdk-11 unit tests
Details
ubuntu-latest jdk-8 unit tests
Details
ubuntu-latest jdk-11 unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
@olafurpg olafurpg deleted the olafurpg:flaky-pants branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.