Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly more compliant initialization of codeActionProvider #1251

Merged
merged 1 commit into from Jan 4, 2020

Conversation

@gabro
Copy link
Member

gabro commented Jan 4, 2020

I don't think this has any practical impact, but it's technically slightly more compliant with the spec.

All the clients I've checked support code action literals anyway.

Copy link
Member

olafurpg left a comment

LGTM

@gabro gabro merged commit 47abe95 into scalameta:master Jan 4, 2020
12 checks passed
12 checks passed
windows-latest jdk-11 unit tests
Details
macOS-latest jdk-11 unit tests
Details
ubuntu-latest jdk-8 unit tests
Details
ubuntu-latest jdk-11 unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
@gabro gabro deleted the gabro:code-action-param branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.