Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --vscode flag to Pants export tool. #1274

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@olafurpg
Copy link
Member

olafurpg commented Jan 8, 2020

Previously, it required several manual steps to use Metals with Pants.
Now, users can run the exporter tool with the --vscode flag to have
everything setup automatically, including installation of the Metals VS
Code extension.

While working on this feature, I hit on a bug in the Doctor where it
would report a warning about non-Scala targets. This commit fixes that
bug by removing non-Scala targets from the doctor list.

Previously, it required several manual steps to use Metals with Pants.
Now, users can run the exporter tool with the --vscode flag to have
everything setup automatically, including installation of the Metals VS
Code extension.

While working on this feature, I hit on a bug in the Doctor where it
would report a warning about non-Scala targets. This commit fixes that
bug by removing non-Scala targets from the doctor list.
@olafurpg olafurpg merged commit e8ebfd7 into scalameta:master Jan 8, 2020
12 checks passed
12 checks passed
windows-latest jdk-11 unit tests
Details
macOS-latest jdk-11 unit tests
Details
ubuntu-latest jdk-8 unit tests
Details
ubuntu-latest jdk-11 unit tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Pants integration
Details
LSP integration tests
Details
Scala cross tests
Details
Scalafmt/Scalafix/Docs
Details
@olafurpg olafurpg deleted the olafurpg:launch-vscode branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.