Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message about unsupported version for RC Scala 3 versions #3114

Merged
merged 1 commit into from Sep 13, 2021
Merged

Fix message about unsupported version for RC Scala 3 versions #3114

merged 1 commit into from Sep 13, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 13, 2021

No description provided.

ckipp01
ckipp01 reviewed Sep 13, 2021
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some valid issues in the Warning suite.

@tgodzik
Copy link
Contributor Author

tgodzik commented Sep 13, 2021

Looks like there are some valid issues in the Warning suite.

Looks like the leftover logic from the Scala milestone days 馃槗

Should be fixed now, let's see

ckipp01
ckipp01 approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGMT!

@tgodzik tgodzik merged commit 913f105 into scalameta:main Sep 13, 2021
@tgodzik tgodzik deleted the fix-rc branch September 13, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgodzik @ckipp01