Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] Install coursier for nightly checks #3543

Merged
merged 1 commit into from Jan 18, 2022

Conversation

dos65
Copy link
Member

@dos65 dos65 commented Jan 18, 2022

I missed that ./coursier is in .gitignore

@@ -10,7 +10,9 @@ jobs:
- uses: olafurpg/setup-scala@v13
- name: "Query maven-central"
run: |
TODAY_NIGHTLY=$(./coursier complete org.scala-lang:scala3-compiler_3: | grep $(date '+%Y%m%d'))
curl -fLo cs https://git.io/coursier-cli-"$(uname | tr LD ld)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that coursier comes olafurpg/setup-scala@v13. If not, could you remove it (- uses: olafurpg/setup-scala@v13)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, instead of using setup-scala here and then manually installing coursier you could also just consider using https://github.com/coursier/setup-action, which will still ensure you have everything you need to use coursier, without any extra work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched it on coursier/setup-action

Copy link
Member

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- uses: olafurpg/setup-scala@v13
- uses: coursier/setup-action@v1
with:
apps: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value of apps is sbtn but there is no need to install it as for this job only jvm and cs is required

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh cool! I didn't know that.

@dos65 dos65 merged commit 833ab36 into scalameta:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants