New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actions] Install coursier for nightly checks #3543
Conversation
@@ -10,7 +10,9 @@ jobs: | |||
- uses: olafurpg/setup-scala@v13 | |||
- name: "Query maven-central" | |||
run: | | |||
TODAY_NIGHTLY=$(./coursier complete org.scala-lang:scala3-compiler_3: | grep $(date '+%Y%m%d')) | |||
curl -fLo cs https://git.io/coursier-cli-"$(uname | tr LD ld)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that coursier
comes olafurpg/setup-scala@v13
. If not, could you remove it (- uses: olafurpg/setup-scala@v13
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, instead of using setup-scala here and then manually installing coursier you could also just consider using https://github.com/coursier/setup-action, which will still ensure you have everything you need to use coursier, without any extra work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switched it on coursier/setup-action
8f4019e
to
d285a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- uses: olafurpg/setup-scala@v13 | ||
- uses: coursier/setup-action@v1 | ||
with: | ||
apps: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. I use this here as well https://github.com/scalameta/nvim-metals/blob/d5864d9395152d4820bcb8a66f1235c5970e46a5/.github/workflows/ci.yml#L63-L65 and don't need to have that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default value of apps is sbtn
but there is no need to install it as for this job only jvm and cs is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh cool! I didn't know that.
I missed that
./coursier
is in.gitignore