chore: enable -Wunused
#3760
Merged
chore: enable -Wunused
#3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 26, 2022 12:04
* cleanup compiler options in build.sbt
remove unused build targets from constructor and refactor common logic in tests
kpodsiad
commented
Mar 28, 2022
build.sbt
Outdated
Comment on lines
288
to
289
| // silence "The outer reference in this type test cannot be checked at run time." in mtags | ||
| "-Wconf:src=.*(CompletionProvider|ArgCompletions|Completions|Keywords).scala&msg=The outer reference:silent" |
There was a problem hiding this comment.
I need to dive into this warning deeper, but for now, I silenced it to have 0 warnings in the problems tab.
Comment on lines
+277
to
+278
| val unused213 = "-Wunused" | ||
| val unused3 = "-Wunused:all" |
There was a problem hiding this comment.
I think it's better to enable all of them and them eventually filter out noisy ones via Wconf
ckipp01
reviewed
Mar 28, 2022
metals/src/main/scala/scala/meta/internal/metals/codelenses/CodeLens.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/formatting/IndentOnPaste.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/worksheets/WorksheetProvider.scala
Outdated
Show resolved
Hide resolved
tgodzik
reviewed
Mar 28, 2022
metals/src/main/scala/scala/meta/internal/worksheets/WorksheetProvider.scala
Outdated
Show resolved
Hide resolved
|
Fatal warnings for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned out we had a lot of unused warnings.