Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement textDocument/documentHighlight #621
Apr 2, 2019
I haven't implemented Write or Read kinds, just used the Text one - so we might need to improve that (though to be fair not sure how to do that properly). And I found that when we have a var in class/object this will also not work when reassigning value since we invoke a method _=
Very exciting! I just gave it a try locally and it's working well
Only nitpick comments on style, there are a lot of undocumented conventions in the codebase that I did my best to explain, please let me know if anything is unclear!
I just tried this locally and it's looking much better than before, nice job handling the trickier cases around synthetic symbols