Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Scalafmt 2.0.0 when setting the version in .scalafmt.conf #806

Merged
merged 2 commits into from Jul 9, 2019

Conversation

@gabro
Copy link
Member

commented Jun 28, 2019

Closes #801

@gabro gabro requested a review from tgodzik Jun 28, 2019
@gabro gabro force-pushed the gabro:scalafmt-version-default branch from b724273 to 232e7bc Jun 28, 2019
@gabro

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

The Azure failure looks legit, but I won't be at a computer until next weekend.
It anyone wants to pick this up feel free, otherwise I'll get back to it when I'm back!

@olafurpg

This comment has been minimized.

Copy link
Member

commented Jun 30, 2019

The test failure is legit and it's caused by a recent regression in scalafmt-dynamic scalameta/scalafmt#1442 We can work around it for now by using an older version of scalafmt-dynamic but still recommend 2.0.0

@gabro

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

@tgodzik the failure in https://dev.azure.com/olafurpg/Metals/_build/results?buildId=649 looks spurious, are you able to restart it?

@tgodzik
tgodzik approved these changes Jul 7, 2019
Copy link
Collaborator

left a comment

Looks good - I restarted the azure tests

@tgodzik

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

I think we can merge, but we need to figure out how to fix the Hover tests - they seem to failing pretty consistently.

@tgodzik tgodzik merged commit a47c0e2 into scalameta:master Jul 9, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
scalameta.metals Build #20190630.2 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.