Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't infer build target for non-readonly files. #810

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@olafurpg
Copy link
Member

commented Jun 30, 2019

A last minute change in the Tree View PR to fix a navigation bug when
browsing library dependenency sources from the tree view resulted in a
performance regression when editing standalone Scala files.
Previously, we tried to infer the build target using an expensive
classloading technique on every completion/hover/signatureHelp request
in standalone files. Now, the expensive technique is only used for files
in the .metals/readonly directory.

A last minute change in the Tree View PR to fix a navigation bug when
browsing library dependenency sources from the tree view resulted in a
performance regression when editing standalone Scala files.
Previously, we tried to infer the build target using an expensive
classloading technique on every completion/hover/signatureHelp request
in standalone files. Now, the expensive technique is only used for files
in the `.metals/readonly` directory.
@tgodzik
tgodzik approved these changes Jul 8, 2019
@tgodzik

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Appveyor is being flaky - unrelated to this PR

@tgodzik tgodzik merged commit 3d09962 into scalameta:master Jul 8, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190630.3 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.