Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting h2.bindAddress to avoid exposing open ports #821

Merged
merged 1 commit into from Jul 9, 2019

Conversation

2 participants
@blast-hardcheese
Copy link
Contributor

commented Jul 9, 2019

Not a great style, but the properties API isn't super great.

@tgodzik
Copy link
Collaborator

left a comment

Thanks for the contribution! 🎉 We just need to reformat the code.

@@ -90,6 +90,7 @@ final class Tables(
else ""
val dbfile = workspace.resolve(".metals").resolve("metals")
Files.createDirectories(dbfile.toNIO.getParent)
System.setProperty("h2.bindAddress", System.getProperty("h2.bindAddress", "127.0.0.1"))

This comment has been minimized.

Copy link
@tgodzik

tgodzik Jul 9, 2019

Collaborator

We need to run scalafmt on the code - can be run using ,/bin/scalafmt

@blast-hardcheese blast-hardcheese force-pushed the blast-hardcheese:close-h2-port branch from e44aeac to 2cdb6ef Jul 9, 2019

@blast-hardcheese

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Not sure what's currently upset, it looks to be failing for reasons outside of just this change?

@tgodzik

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

The failure is not related, thanks for fixing the formatting issue!

@tgodzik tgodzik merged commit f74e7dd into scalameta:master Jul 9, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190709.3 succeeded
Details

@blast-hardcheese blast-hardcheese deleted the blast-hardcheese:close-h2-port branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.