Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve symlinks from client requests #824

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@marek1840
Copy link
Collaborator

commented Jul 10, 2019

Previously, we were using paths from the clients without resolving symlinks to real paths.
This made resolving build targets impossible whenever workspace or one of its ancestors were a symlink.

Now, we dealias paths coming from the client.

closes #823

@marek1840 marek1840 requested a review from tgodzik Jul 10, 2019
@marek1840 marek1840 merged commit 7f85d79 into scalameta:master Jul 10, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190710.1 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.