Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of the java sources #825

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@marek1840
Copy link
Collaborator

commented Jul 11, 2019

Previously Metals was directories with names starting with jdk as proper jdk home candidates.
Now, we consider those containing jdk, since java-8-openjdk would obviously fail the test.
Also, we notify the user that the sources were not found and that the java symbols will not be available.

Previously, we were checking if the folder name started with `jdk`.
It is not sufficient for openjdk installations.

e.g. /usr/lib/jvm/java-8-openjdk
@marek1840 marek1840 requested a review from tgodzik Jul 11, 2019
@marek1840 marek1840 force-pushed the marek1840:imporve-handling-java-sources branch from fa6a42e to 77bd8bd Jul 11, 2019
@tgodzik tgodzik changed the title Imporve handling of the java sources Improve handling of the java sources Jul 11, 2019
@marek1840 marek1840 merged commit 9963cec into scalameta:master Jul 22, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190711.2 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.