Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline edits #826

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Jul 12, 2019

Fix multiline edits by switching from long single edit to multiple edits in the document.
Long edits spanning multiple lines are not supported by some of the LSP clients.

Fixes #774

@tgodzik tgodzik requested a review from marek1840 Jul 12, 2019
@tgodzik tgodzik force-pushed the tgodzik:fix-multiline-edits branch from 7d5bbb4 to f155434 Jul 12, 2019
@tgodzik tgodzik force-pushed the tgodzik:fix-multiline-edits branch from f155434 to 8df170a Jul 12, 2019
…its in the document
@tgodzik tgodzik force-pushed the tgodzik:fix-multiline-edits branch from 8df170a to 68565c1 Jul 15, 2019
@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 15, 2019

Failing tests unrelated - TreeView one is failing everywhere - will investigate.

@tgodzik tgodzik merged commit 3a3fb99 into scalameta:master Jul 15, 2019
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
scalameta.metals Build #20190715.1 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tgodzik tgodzik deleted the tgodzik:fix-multiline-edits branch Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.