Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mercury blog post date by adding an unlisted redirect #836

Merged
merged 2 commits into from Jul 24, 2019

Conversation

@gabro
Copy link
Member

commented Jul 22, 2019

This uses a new feature of Docusaurus 1.12.0, contributed by @olafurpg 馃帀, which allows marking blog posts as unlisted.

With this, we can:

  • republish the faulty blog post with the correct date
  • make the old post point to the new one and make it unlisted

This way old links will continue to work.

NOTE
During development, unlisted blog posts are still visibile, so we will still see the "redirect" blog post when doing yarn start.

To test this change, I did:

yarn build
npx http-server build

image

This is what the old link will point to. Notice the absence of this particular entry in the sidebar.

@gabro gabro requested a review from tgodzik Jul 22, 2019
Copy link
Collaborator

left a comment

Really cool! Finally my OCD can go to rest 馃槅

@gabro

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

@tgodzik I've installed https://github.com/apps/merge-when-green on the Metals repo to try it out. Let's see whether it works :D

@tgodzik

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

@tgodzik I've installed https://github.com/apps/merge-when-green on the Metals repo to try it out. Let's see whether it works :D

We should probably turn on the setting requiring at least on approval.

Also I think one test is currently broken :O

@gabro

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

Also I think one test is currently broken :O

I'll take care of it soon! It seems a minor node issue

@gabro

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

We should probably turn on the setting requiring at least on approval.

The merge is not entirely automatic, it still requires adding the label. I was thinking of adding the label after a successful review (like I did here).

The thing we definitely need to configure is to wait for all tests (including AppVeyor and Azure)

@gabro gabro force-pushed the gabro:fix-blog-post-date branch 4 times, most recently from e1c9fcb to 8af2388 Jul 22, 2019
@gabro gabro force-pushed the gabro:fix-blog-post-date branch from 8af2388 to be1fe9d Jul 24, 2019
@gabro

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

AppVeyor failure looks spurious. Merging.

@gabro gabro merged commit 05d0e46 into scalameta:master Jul 24, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190724.4 succeeded
Details
@gabro gabro deleted the gabro:fix-blog-post-date branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.