Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exact libraries that are expected and fix the test #837

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@tgodzik
Copy link
Collaborator

commented Jul 22, 2019

The test seems to have a random number of libraries shown, which is pretty weird.

I added the exact current libraries to see next time what changes.

@tgodzik tgodzik requested review from gabro and marek1840 Jul 22, 2019
@gabro

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

The test seems to have a random number of libraries shown

what you mean by random?

@tgodzik

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2019

The test seems to have a random number of libraries shown

what you mean by random?

It was 22 at some point and now it's 30 without any changes to actual dependencies.

@gabro
gabro approved these changes Jul 22, 2019
Copy link
Member

left a comment

👌

@tgodzik tgodzik merged commit c977ae1 into scalameta:master Jul 22, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
scalameta.metals Build #20190722.2 succeeded
Details
@tgodzik tgodzik deleted the tgodzik:fix-tree-view-test branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.